-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove edit gallery toolbar button #16778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally feel it's better because the way that button worked was confusing and now we can move, remove and add images without opening the media library (inline).
We might need a button in the image itself to edit one image (The last mockup here should be a good starting point #11952)
That said, let's have more thoughts here @karmatosed @mapk @mtias @kjellr
Interesting. As others noted in the previous thread, the main thing missing here is the ability to edit metadata for individual images. Maybe we should add in a control like this? Anyway, as long as we have a plan for that, I think it's probably okay to remove this menu item. (As an aside, I originally missed those move controls, so I opened a PR to help make them a little larger. Really though, I can't wait for drag & drop to happen for these — I imagine that'll be the primary way of rearranging galleries for many people.) |
Nevermind, I had the Gallery block hidden in the Block Manager. It's working as expected! Basically, I was definitely Gutenberging wrong. |
Hi @mapk, is that a green light :)? |
4e19d05
to
bdece04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good to go! Thanks!
Description
This PR follows the suggestion discussed on #16548 (comment) and removes the edit gallery button from the gallery block.
How has this been tested?
I created a gallery I added some images and I verified the edit gallery button does not appear on the block toolbar.