Fix: Widgets screen block toolbar overlaps the Block Area accordion #16765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ellatrix,
talldan and
youknowriad
as code owners
draganescu
requested changes
Aug 5, 2019
jorgefilipecosta
force-pushed
the
fix/widgets-screen-block-toolbar-overlaps-the-block-area-accordion-trigger
branch
from
4a5e61f to
93390bf
Compare
|
Hi @draganescu, thank you for the review the dimensions were updated it should work as expected now. |
|
I just tested and no longer see an overlap in FF or in Chrome. Thanks! This looks good to 🚢 .
|
jorgefilipecosta
deleted the
fix/widgets-screen-block-toolbar-overlaps-the-block-area-accordion-trigger
branch
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #16602
This PR adds small padding to the block list container for widget areas to make sure the block toolbars don't overlap the block area accordion.
How has this been tested?
I went to the block widgets screen.
I added a block like an image block and verified the block toolbar does not overlap the block area accordion.