-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinner Component: Added design documentation and image #16760
Conversation
A few suggestions on this one: Before:
After:
Before:
After:
Before:
After:
Let me know if you have any concerns with these suggested edits -- I mostly wanted to avoid the passive voice as much as possible, and to make sure the second bullet point conforms to the "Should" construction that prepares it. |
No concerns, these tweaks look great. I have updated accordingly. Thanks for the review! |
The spinner component should: | ||
|
||
- Signal to users that the processing of their request is underway and will soon complete. | ||
- Not appear when pages or data are loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify this Not appear when pages or data are loading.
? Isn't this the whole purpose of the spinner component (data being loaded)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep this is a good question. The thinking here is that future forward it's ideal to have different kinds of feedback or progress indicators, each with their own purpose. Since the spinner is the only progress indicator we have I jumped the gun with this guidance.
Future component descriptions might look something like this:
Spinner: An action is being processed with an unspecified amount of wait time. They should be used when progress isn’t detectable, or if it’s not necessary to indicate how long an activity will take.
Progress bar: Used to indicate to users that a page is loading or an upload is processing. It shows how much of the task has been completed and how much is left.
In the meantime I can remove Not appear when pages or data are loading
until we hopefully add a Progress bar component.
Removed guidelines, "Not appear when pages or data are loading."
Description
Added a description of the component, design documentation, and an image.