Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): remove nonexistent getBlockDependantsCacheBust selector reference #16756

Merged
merged 2 commits into from
Jul 26, 2019
Merged

fix(editor): remove nonexistent getBlockDependantsCacheBust selector reference #16756

merged 2 commits into from
Jul 26, 2019

Conversation

dsifford
Copy link
Contributor

Description

This PR removes a selector reference from core/editor that references a deleted selector in core/block-editor

How has this been tested?

Unit tests still pass.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@youknowriad
Copy link
Contributor

You should run npm run docs:build to regenerate the docs too.

@dsifford
Copy link
Contributor Author

Got it. I'm on it...

youknowriad
youknowriad approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad youknowriad merged commit e54043a into master Jul 26, 2019
@youknowriad youknowriad deleted the fix/remove-nonexistent-selector-reference branch July 26, 2019 07:41
@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@talldan talldan Awaiting requested review from talldan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@mkaz mkaz Awaiting requested review from mkaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dsifford @youknowriad