Fix: Close "Block Styles" section on transformBlockTo e2e test helper. #16739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
youknowriad
as code owners
jorgefilipecosta
force-pushed
the
fix/close-block-styles-panel-on-transform-block-to
branch
from
d5158ac to
f34daaa
Compare
getdave
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Hi @jorgefilipecosta. Thank you so much for working on this and sorry it's taken so long for me to get around to testing.
I'm back on BlockPreview this week and I've just tested this branch by following your instructions and everything now works perfectly. Therefore I think we're good to merge.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
youknowriad
deleted the
fix/close-block-styles-panel-on-transform-block-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pr #16113, the end to end tests are failing, because, during a transform test a button is not visible in the test screen height (that PR increases the height of block style buttons). This PR fixes the problem by first closing the "Block Styles" button. This change replicates the same a human user would have to do to press the transform button in that screen resolution.
How has this been tested?
Merge #16113 temporarily in this branch and verify end to end transform tests pass:
npm run test-e2e packages/e2e-tests/specs/block-transforms.test.js