-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/plugin document setting panel docs #16620
Fix/plugin document setting panel docs #16620
Conversation
docs/designers-developers/developers/slotfills/plugin-document-setting-panel.md
Show resolved
Hide resolved
🚢 ! |
docs/designers-developers/developers/slotfills/plugin-document-setting-panel.md
Outdated
Show resolved
Hide resolved
title="Custom Panel" | ||
className="custom-panel" | ||
> | ||
Custom Panel Contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an example to edit a document setting (a meta field for instance) could be more valuable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion - perhaps we should apply this feedback to the other docs for SlotFill as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense.
Also, I feel having a "slotfills" category/section in the docs is also a bit misleading. I'd personally prefer extensibility options organized in a more "semantic way".
Instead of SlotFills section, we could have:
- Block extensibilty APIs
- Publishing flow extensibiltiy APIs
- Document extensibility APIs
we could continue these adaptations separately.
Thanks for the update on this one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is an automated way to do that, via some kind of jsdoc tag to move slotfills into a more self-documented approach? (Just a musing!)
Description
Adds documentation for the
PluginDocumentSettingPanel
SlotFill. Closes #16619Types of changes
Documentation