Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Replace use of deprecated componentWillReceiveProps in ImageEdit #16577

Merged
merged 1 commit into from
Jul 15, 2019
Merged

[RNMobile] Replace use of deprecated componentWillReceiveProps in ImageEdit #16577

merged 1 commit into from
Jul 15, 2019

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 13, 2019 •
edited
Loading

Description

For mobile, replaces the native image component's use of the deprecated componentWillReceiveProps component lifecycle method in order to remove a warning. Additional detail, including testing directions, can be found in the related gutenberg-mobile PR.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mchowning mchowning added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 13, 2019
@mchowning mchowning mentioned this pull request Jul 13, 2019
Merged
@mchowning mchowning self-assigned this Jul 13, 2019
etoledom
etoledom approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Thank you @mchowning for taking care of this

@mchowning mchowning merged commit 4fa8431 into master Jul 15, 2019
@mchowning mchowning deleted the rnmobile/remove_image_component_use_of_componentWillReceiveProps branch July 15, 2019 16:37
@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

Assignees

@mchowning mchowning

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mchowning @etoledom @youknowriad