Fix aspect ratio typo and recalculate padding in embed block CSS #16573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @jasmussen here, there is a typo in the selector for the 9:16 aspect ratio. The ratio is listed accurately here:
gutenberg/packages/block-library/src/embed/style.scss
Lines 19 to 26 in 429558a
But here it has been changed to 9:6:
gutenberg/packages/block-library/src/embed/style.scss
Lines 66 to 68 in 429558a
Given that aspect ratios are sorted in ascending order by the required top padding, it appears the second code excerpt should be:
This pull request fixes the typo and recalculates the value for
padding-top
.I considered whether the intention could be to use 9:6 as an aspect ratio in addition to 9:16, but presumably that would have been listed as 3:2, so I believe 9:16 was the intended aspect ratio all along.
Checklist: