Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ./node_modules/ from require in example #16470

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Jul 8, 2019

Description

Noticed this when following the example for configuring webpack. Node will automatically resolve modules from the node_modules directory, so ./node_modules/ doesn't need to be listed in the require.

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Node will automatically look in the node_modules directory, so listing it isn't needed
@Soean Soean added the [Type] Developer Documentation Documentation for developers label Jul 9, 2019
@aduth
Copy link
Member

aduth commented Jul 9, 2019

Thanks for the improvement!

@aduth aduth merged commit bd23075 into WordPress:master Jul 9, 2019
@github-actions github-actions bot added this to the Gutenberg 6.2 milestone Jul 9, 2019
@ajlende ajlende deleted the patch-1 branch February 28, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants