-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tapping on an empty editor area creates a new paragraph block #16439
Tapping on an empty editor area creates a new paragraph block #16439
Conversation
…reates-empty-paragraph-block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works great as expected! 🎉
Nice call using the list footer @marecar3
Great job!
Thanks @etoledom ! |
Nice job @marecar3 ! This works very well! I do see two small issues in testing this. 1: Tapping footer adds block below selected blockIf a block is selected, then tapping the footer inserts the new paragraph block underneath that selected block instead of at the end of the post. I observed this behavior on both Android and iOS. My assumption was that we wanted the footer to always insert the new block at the end of the post, but I admittedly didn't see that specifically called out in the discussion of the issue. Steps to reproduce:
2: Keyboard disappearance and reappearance is more noticeable nowThis issue is pretty minor, but on Android when we add an empty paragraph after an already empty paragraph the keyboard is dismissed and immediately reappears. This hasn't been noticeable until now because the add bottom sheet hides it (mostly). It is just more noticeable now when you add an empty paragraph block by tapping the footer after an empty paragraph block because there is no bottom sheet to hide it. Admittedly, this is a very edge case with minimal user impact (and the result of behavior that existed before this PR), but I wanted to point it out. I do not observe this issue on iOS. Steps to reproduce:
|
Good catch @mchowning ! |
This PR introduces tappable empty editor area which creates a new paragraph block.
Related Gutenberg PR: wordpress-mobile/gutenberg-mobile#1200