Remove "Change Permalinks" button when permalink is not editable #16395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Feature] Permalink
|
Looks great! I don't see any "Change Permalinks" button anymore. Thanks, @jorgefilipecosta!
|
jorgefilipecosta
deleted the
fix/remove-change-permalink-button-when-permalink-is-not-editable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #12498
When we are editing a page that is the homepage of a website, the Permalink UI shows a Change Permalinks button that links to the settings page allowing the user to change the site-wide permalink structure. Given that the user pressed a link on a specific page, the user may not be aware a site-wide change is being applied.
This PR follows @mapk suggestion and removes the button.
How has this been tested?
I created a new page published it.
I went to the customizer, I selected "Homepage Settings" section, I set the page created on the previous step as the Homepage.
I opened the page in the editor and I verified 'Change Permalinks' was not available in the permalink editor.