Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow inner block template options to wrap #16371

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Allow inner block template options to wrap #16371

merged 2 commits into from
Jul 1, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jul 1, 2019

As noted in #16255 (comment), it appears that the InnerBlocks template options buttons get cut off on mobile, or at high levels of zoom. This PR allows template options to wrap, which fixes the mobile/zoom issue, and also allows for more flexibility in the number of template options presented.

Before Screenshots

columns-responsive-before

Example with 10 items:

Screen Shot 2019-07-01 at 9 55 02 AM

After Screenshots

columns-responsive

Example with 10 items:

Screen Shot 2019-07-01 at 9 53 37 AM

@kjellr kjellr added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P labels Jul 1, 2019
@kjellr kjellr requested review from jasmussen and aduth July 1, 2019 13:58
@kjellr kjellr self-assigned this Jul 1, 2019
jorgefilipecosta
jorgefilipecosta approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests 👍 The changes make sense!

@kjellr kjellr merged commit 496a02c into master Jul 1, 2019
@kjellr kjellr deleted the update/inner-blocks-template-picker-responsive branch July 1, 2019 17:55
@kjellr kjellr added this to the Gutenberg 6.1 milestone Jul 1, 2019
@kjellr kjellr mentioned this pull request Jul 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@jasmussen jasmussen Awaiting requested review from jasmussen

@aduth aduth Awaiting requested review from aduth

@ellatrix ellatrix Awaiting requested review from ellatrix

@gziolo gziolo Awaiting requested review from gziolo

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@kjellr kjellr

Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kjellr @jorgefilipecosta