Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] document missing prop in MenuItem #16061

Merged

Conversation

dsifford
Copy link
Contributor

@dsifford dsifford commented Jun 9, 2019

Description

isSelected was not documented for MenuItem and that prop is not inherited from IconButton or Button.

How has this been tested?

N/A

Types of changes

Documentation

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing it 👍

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Jun 10, 2019
@gziolo gziolo merged commit 3550aad into WordPress:master Jun 10, 2019
@github-actions github-actions bot added this to the Gutenberg 5.9 milestone Jun 10, 2019
@dsifford dsifford deleted the dsifford-docs-components/menu-item branch June 10, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants