Fix: Alt and caption text written on images while the image was temporary is deleted. #16051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
gziolo,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
jorgefilipecosta
added
the
[Feature] Media
epiqueras
previously requested changes
Jul 25, 2019
| const { id, url, alt } = this.props.attributes; | ||
| // If the current image is temporary but an alt text was meanwhile wrotten by the user, | ||
| // make sure the text is not overwritten. | ||
| if ( alt && isTemporaryImage( id, url ) ) { |
There was a problem hiding this comment.
Let's also take care of the caption here so that this can also close #16746 .
jorgefilipecosta
force-pushed
the
fix/upload-deletes-alt-written-during-image-upload
branch
from
86b3eea to
f5a01f2
Compare
jorgefilipecosta
changed the title
|
Hi @epiqueras, thank you for reviewing this PR! The PR was rebased and updated to also deal with the caption. |
jorgefilipecosta
force-pushed
the
fix/upload-deletes-alt-written-during-image-upload
branch
from
f5a01f2 to
b5e62ef
Compare
jorgefilipecosta
dismissed
epiqueras’s stale review
The suggestion was applied.
…ted when the upload finishes.
jorgefilipecosta
force-pushed
the
fix/upload-deletes-alt-written-during-image-upload
branch
from
b5e62ef to
b92780e
Compare
jorgefilipecosta
deleted the
fix/upload-deletes-alt-written-during-image-upload
branch
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
…ted when the upload finishes. (#16051)
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
…ted when the upload finishes. (#16051)
|
This issue had been solved but I am seeing it just cam back when using Gutenberg 8.3.0 (this is not happening with the current core version of the block editor only if the plugin is active). I was also able to reproduce this on a WordPress.com simple site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12202, #16746
Currently, the image alt text written while the image is temporary (points to a blob URL) is deleted as soon as the upload finishes.
This PR fixes the problem.
Alt attribute is not set when the upload is complete if the current image is temporary and an alt already exists.
Description
How has this been tested?
(to make the upload slow I used chrome dev tools network throttling)
I added an image block, I pressed the upload button, while the image is uploading I wrote some alt text. I verified that the al text was persisted when the upload finished.
I repeated the same test but instead of adding an image block I drag&dropped an image directly to the editor.
I added an image I wrote some alt text. I drag & dropped another image to replace the current image, I waited for the upload to complete and I verified the alt text was removed.