Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video block has black background when upload is in progress or upload has failed #15991

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Video block has black background when upload is in progress or upload has failed #15991

merged 3 commits into from
Jun 5, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Jun 4, 2019 •
edited
Loading

Fixes : wordpress-mobile/gutenberg-mobile#1066

It's regression caused by #15857

To test :

Build WPiOS and WPAndroid against gutenberg-mobile PR : wordpress-mobile/gutenberg-mobile#1068

@marecar3 marecar3 requested review from daniloercoli and pinarol June 4, 2019 21:48
@marecar3 marecar3 mentioned this pull request Jun 4, 2019
Merged
@marecar3
Copy link
Contributor Author

marecar3 commented Jun 4, 2019

Hey @daniloercoli @pinarol, when I build WPAndroid against reverted changes from : #15857, I can't reproduce this issue : wordpress-mobile/WordPress-Android#9943

Is it maybe some Android platform version specific problem? I tried on 8.1 and 9.0 and it worked very well?

@daniloercoli
Copy link
Contributor

Is it maybe some Android platform version specific problem? I tried on 8.1 and 9.0 and it worked very well?

No @marecar3 - The issue was there on all versions of Android we tested. Android 9 and Android 7.1 were the ones I personally tested on real devices.

@daniloercoli daniloercoli added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 5, 2019
@pinarol
Copy link
Contributor

pinarol commented Jun 5, 2019

@marecar3 @daniloercoli I have updated the fix to add a wrapper View around Video just to be able to give the same background color for both platforms. If you can give it a try that'd be great.

@marecar3
Merge branch 'master' into rnmobile/1066-Video-block-has-black-backgr…
c9f2584 
…ound-when-upload-is-in-progress-or-upload-has-failed
@marecar3
Copy link
Contributor Author

marecar3 commented Jun 5, 2019

Test on both iOS and Android and it's working! Thanks @pinarol for jumping in! :)

daniloercoli
daniloercoli approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marecar3 marecar3 merged commit 4c2eb54 into master Jun 5, 2019
@marecar3 marecar3 deleted the rnmobile/1066-Video-block-has-black-background-when-upload-is-in-progress-or-upload-has-failed branch June 5, 2019 16:53
@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol left review comments

@daniloercoli daniloercoli daniloercoli approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 5.9
Development

Successfully merging this pull request may close these issues.

[iOS] Video block has black background when upload is in progress or upload has failed
4 participants
@marecar3 @daniloercoli @pinarol @youknowriad