Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlayColor class name to cover blocks editor markup (#15897) #15939

Merged
merged 1 commit into from
May 31, 2019

Conversation

oxyc
Copy link
Member

@oxyc oxyc commented May 31, 2019

Description

Added the overlayColor class name to the block markup when rendered in the editor. Same as the block does in the view function from before. See #15897

How has this been tested?

Ran the local development environment and verified that the class gets added in the editor.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for your contribution @oxyc!

@jorgefilipecosta jorgefilipecosta added this to the 5.9 (Gutenberg) milestone May 31, 2019
@jorgefilipecosta jorgefilipecosta merged commit 31e0e44 into WordPress:master May 31, 2019
@youknowriad youknowriad added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants