-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media+Text block: Remove break-all
styling
#15871
Conversation
…eak at the word.
To test this: 1. Text this in the Firefox browser. The latter is the correct solution. It should drop the entire word to the second line and not break word in the middle. |
Noting that it was added in #14951 by @marekhrabe to fix some other issues. So it should be retested in that context as well. |
Thanks @gziolo! I knew it was there for a reason but forgot. @marekhrabe any thoughts on this? After reviewing it from a design perspective, I'd like to just break at whole words. It feels better and visually makes more sense. When breaking at letters, the breaks look very odd, especially when there's plenty of space in the content area of the block. I'm willing to take the tradeoff of words expanding outside the block border in edge cases (really narrow text areas) over words breaking in the middle in more common width scenarios. |
The problem was with the drag & drop resizing action: In some cases, words could overflow outside of the box and thus changing the width of the element. That caused a janking effect as the media width is defined as a percentage but the base size was also changing constantly. It was definitely an edge case and seemed to be browser specific so for greater good, I think we should probably give this issue a priority as it applies everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected and in accordance with @marekhrabe comment:
That caused a janking effect as the media width is defined as a percentage but the base size was also changing constantly. It was definitely an edge case and seemed to be browser specific so for greater good, I think we should probably give this issue a priority as it applies everywhere.
I think we should merge this change 👍
Thanks @jorgefilipecosta! |
Fixes #15870. Removes the from the editor.scss file allowing it to break at the word.
Description
In Firefox, the content of this block would break in the middle of a word. It shouldn't.
How has this been tested?
Tested locally.
Screenshots
Types of changes
Minor CSS change.
Checklist: