Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline docs and add tests for color utils #15861

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Fix inline docs and add tests for color utils #15861

merged 2 commits into from
Jun 4, 2019

Conversation

swissspidy
Copy link
Member

Description

I noticed that the stated return values for getColorObjectByAttributeValues, getColorObjectByColorValue, and getColorClassName were not entirely accurate.

This PR fixes that, and also adds some tests.

How has this been tested?

New tests added.

Types of changes

Bug fix (non-breaking change which fixes an issue). Documentation change only.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@swissspidy swissspidy added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Package] Block editor /packages/block-editor labels May 28, 2019
@swissspidy swissspidy changed the title Fix/colors utils docs tests Fix inline docs and add tests for color utils May 28, 2019
@gziolo gziolo requested a review from jorgefilipecosta May 28, 2019 09:52
@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 29, 2019
@swissspidy swissspidy merged commit fc08af8 into master Jun 4, 2019
@swissspidy swissspidy deleted the fix/colors-utils-docs-tests branch June 4, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@gziolo gziolo Awaiting requested review from gziolo

@talldan talldan Awaiting requested review from talldan

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees
No one assigned
Labels
[Package] Block editor /packages/block-editor [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 5.9
Development

Successfully merging this pull request may close these issues.
3 participants
@swissspidy @youknowriad @gziolo