[RNMobile] Fix link "open in new tab" switch #15812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
1 task
mkevins
reviewed
May 27, 2019
| @@ -53,10 +53,13 @@ class ModalLinkUI extends Component { | |||
| return; | |||
| } | |||
|
|
|||
| const { activeAttributes: { url, target } } = this.props; | |||
mkevins
approved these changes
May 27, 2019
|
I'll move this PR forward since Eduardo is AFK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1018
gutenberg-mobileside PR: wordpress-mobile/gutenberg-mobile#1030This PR fixes the "Open in New Tab" option for links in gutenberg-mobile, where the switch started always off, even a link target was set.
To test: