Add widget scripts to the block editor for widgets page. #15787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Priority] High
jorgefilipecosta
requested review from
aduth,
gziolo and
youknowriad
as code owners
jorgefilipecosta
force-pushed
the
add/widget-scripts-to-the-widget-block-editor-page
branch
from
fb290ea to
aa0c41b
Compare
noisysocks
reviewed
May 23, 2019
jorgefilipecosta
force-pushed
the
add/widget-scripts-to-the-widget-block-editor-page
branch
from
aa0c41b to
3c02823
Compare
jorgefilipecosta
force-pushed
the
add/widget-scripts-to-the-widget-block-editor-page
branch
from
3c02823 to
1daffdd
Compare
|
The code was updated, to follow the approach suggested by @noisysocks. Thank you for the review 👍 |
noisysocks
approved these changes
May 24, 2019
jorgefilipecosta
deleted the
add/widget-scripts-to-the-widget-block-editor-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just loads the scripts/styles loaded in the widgets screen in the widget block editor page.
These artifacts were already being loaded in the post editor and they are required to make sure legacy widgets work properly.
How has this been tested?
I verified I can trigger jQuery events on the widgets page by exectuing
window.$( window.document ).trigger( 'my-widget-event' );, on the console. On master this code crashes