Framework: Consolidate Docker commands in site installation #15742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15159
This pull request seeks to update
bin/install-wordpress.sh
in an effort to reduce the number of individualdocker-compose
commands where consolidation is straight-forward.Each of the affected commands supports multiple arguments:
mkdir
: https://linux.die.net/man/1/mkdirchmod
: https://linux.die.net/man/1/chmodwp plugin install
: https://developer.wordpress.org/cli/commands/plugin/install/Proposed benefit: Anecdotally, each
docker-compose
command takes upwards of seconds to run, thus encouraging that we reduce the number in the install script. This will shorten build times for Travis and setup times for local end-to-end test runs and environment setups. Additional Docker improvements are proposed at #15159. This will likely have a more minimal impact, but is most trivial to implement.Testing Instructions:
Verify fresh Docker environments setups for end-to-end tests (and optionally local development).
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/getting-started.md#local-environment
Verify Travis build passes.