Builld Tooling: Skip Chromium download in Travis by default #15712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Truthy consideration: https://github.com/GoogleChrome/puppeteer/blob/c6c32491ec0a0209ab651c098e955d15c9305ab9/install.js#L23 Boolean( "false" ) === true
|
Sharing from another PR for comparison: |
|
This branch:
|
gziolo
approved these changes
May 20, 2019
|
Yeah, on average looks to be about 10 seconds savings per job. Not as great as I'd hoped either, but better than nothing for a simple adjustment. |
swissspidy
added a commit
to ampproject/amp-wp
that referenced
this pull request
May 21, 2019
This happens because the wordpress/scripts package depends on Puppeteer, which results in attempts to download Chromium when running `npm install`. Once we use Puppeteer for end-to-end tests that can be run on Travis, we can enable the download again just for that stage. Related: WordPress/gutenberg#15712
|
We should use this env variable in the plugin build script as well. |
|
Yep, you can add it to the release script 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15667, #15159
This pull request seeks to skip Puppeteer's Chromium download in all Travis tasks except end-to-end containers. The proposed benefit is to help reduce the build time in non-end-to-end tasks, since the Chromium download can be time-consuming with its large size, and is unnecessary.
It may be possible to revert this optimization if and when a more general solution proposed in #15667 is implemented.
Testing Instructions:
Verify the Travis build passes.