[Mobile] Fix caret position after inline paste - after selection refactor #15701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevins
added
[Feature] Rich Text
mkevins
commented
May 17, 2019
mkevins
commented
May 28, 2019
gziolo
added
Mobile App - i.e. Android or iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is part of a series of PRs to fix the same issue. Most recently, a change in ownership of selection state has brought about an important refactor which regressed the previous PR before it was merged: #15552. The solution there is no longer viable, but the unit test in that PR may still serve as a helpful tool to prevent more regressions.
Description
This PR is intended to fix a regression of part of this issue: wordpress-mobile/gutenberg-mobile#828 , specifically, when inline content is pasted.
Companion PR.
How has this been tested?
This has been tested using the steps here:
wordpress-mobile/gutenberg-mobile#828 (comment)
Types of changes
This is a bug fix, but currently only resolves a part of the original issue. It serves as an incremental improvement. Also, this PR renames some local variables for clarity.
Checklist: