Fix: Disabled block switcher icons are blurry #15643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
requested review from
ellatrix,
noisysocks,
talldan and
youknowriad
as code owners
gziolo
force-pushed
the
fix/block-no-switcher-icon
branch
from
6943126 to
3f1a8af
Compare
kjellr
reviewed
May 15, 2019
There was a problem hiding this comment.
This definitely fixes the issue. All the icons look perfectly crisp with this PR:
I'll hold off for a developer's input on the actual method used. But I can confirm that this absolutely solves the problem. I don't see any negative effects to other block switcher icons either. Thanks, @gziolo!
|
I think that having both Travis and @kjellr happy is enough to proceed but I will wait for ✅ :) |
gziolo
added
the
Good First Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15629.
It looks like
IconButtonhas a very unexpected logic for addinghas-textclass. It adds it when children prop is passed which was the case. However, an icon isn't really the text 🤷♂Before
When the block switcher is disabled, the block icon inside of it appears smaller than it should, resulting in some blurry icons on non-retina screens. Here's the Container block icon for instance, appearing at
20pxwide:For comparison, here's a non-disabled icon, which renders at the correct
24pxwide:Screenshots
After