[RNMobile] Moving native tests to gutenberg repo #15589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
To be able to use the same structure already in place.
koke
reviewed
May 15, 2019
| expect( component.exists() ).toBe( true ); | ||
| } ); | ||
|
|
||
| it( 'splits empty block on Enter', () => { |
There was a problem hiding this comment.
Minor nitpick, specially since I think this is just a file move, but since there's no actually Enter keypress involved in this test, I wouldn't mention it on the test name
There was a problem hiding this comment.
Nice catch! Removed the reference to "on Enter".
etoledom
changed the title
* Add unit test for willTrimSpaces. * Fix willTripSpaces to report false for no outer spaces on styled text. * Ignore gutenberg-mobile unit tests in gutenberg test pipeline * Revert "Fix willTripSpaces to report false for no outer spaces on styled text." This reverts commit 0731689. Upstream changes make this implementation no longer necessary. * Fix lint issues * Import RichText without native extension * Remove stubs from rich-text __mocks__
etoledom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobileside PR: wordpress-mobile/gutenberg-mobile#977This PR moves some of the
mobile-gutenbergtest suits to thegutenbergrepo.Added an exception to
test/unit/jest.config.jsso these tests are not run bynpm run test-unit.As a intermediate step, these tests will continue to be run only from
gutenberg-mobilecheckout viayarn test.On a next step we plan to integrate these mobile tests to the
gutenbergtool-chain.To test:
gutenbergrunrpm run test-unit