Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN Mobile] Fix crash when merging block #15392

Merged
merged 29 commits into from
May 15, 2019
Merged

[RN Mobile] Fix crash when merging block #15392

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
99218df
Adding `onSelectionChange` from store to RichText
etoledom Apr 29, 2019
4f873c3
First experiment fixing selection change handling in rich text
Tug May 2, 2019
b0cf148
Update readme change postcommit
Tug May 2, 2019
6951224
Fix sequence of events on split and selection change
Tug May 3, 2019
763a870
Remove commented onTextUpdate call on enter pressed
Tug May 3, 2019
ba8f400
Do not reset activeFormats when onSelectionChange is emitted while ty…
Tug May 6, 2019
0e1d233
Update value from props
Tug May 6, 2019
3bd6a25
Pinpoint conditions for the case where onSelectionChange is emitted w…
Tug May 6, 2019
b898e7b
Improve isTyping detection
Tug May 7, 2019
d4651cb
Fix applying link format
Tug May 7, 2019
1ad6132
Do not try to update text from the paste handler
Tug May 8, 2019
9b91cf1
onChange should update the state
hypest May 9, 2019
77bb219
Selection change events always fire after text already changed
hypest May 9, 2019
cc12da7
Fix issue where the list block was not being selected on focus.
etoledom May 9, 2019
1421cdd
Add isSelected prop from context to RichText
etoledom May 9, 2019
86894ea
Fix move caret to the end when merging.
etoledom May 9, 2019
2f67beb
Caret position from props, don't force to end
hypest May 10, 2019
f7d0169
Fix lint errors
hypest May 12, 2019
e2b77fb
WIP: more fixes
hypest May 12, 2019
680aada
WIP: Fix list external Enter key on Android
hypest May 12, 2019
586f076
No stray onSelectionChanged events from AztecAndroid
hypest May 12, 2019
380660e
Only block html elements will be trimmed by AztecAndroid
hypest May 13, 2019
1b29e88
Mirror caret state on text change
hypest May 13, 2019
8e812c7
Fix issue on iOS where the format buttons were not working properly.
etoledom May 13, 2019
404173d
Restore iOS autoscroll while editing.
etoledom May 13, 2019
a9d1540
Merge commit '295a381838c03ace2d239a6cbb426b1285c1cc69' into rnmobile…
hypest May 14, 2019
716c775
Cleanup
hypest May 14, 2019
9df1bb3
Try a new approach to detect if the selection change event is manual …
Tug May 14, 2019
50527d3
Fix iOS issue with formats, where pressing the format buttons sometim…
etoledom May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading