Fix: DateTimePicker styles don't load as expected outside WordPress context #15389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
jorgefilipecosta
added
[Type] Bug
youknowriad
added
the
Good First Review
aduth
approved these changes
May 31, 2019
There was a problem hiding this comment.
Reference styles:
https://github.com/WordPress/WordPress/blob/13da094c39e345c62210b7177cb3c31291589530/wp-admin/css/common.css#L2446-L2450
https://github.com/WordPress/WordPress/blob/13da094c39e345c62210b7177cb3c31291589530/wp-admin/css/forms.css#L311-L316
I'm not sure the input styles are necessary? Shouldn't have an impact at least.
jorgefilipecosta
deleted the
fix/datetimepicker-component-styles-dont-load-as-expected
branch
|
Hi @aduth I tried to removed the input styles, and the result was unexpected: So I decided to keep them if I missed something feel free to comment, and I will open a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8870
I started this PR with the objective of closing #8870 which is a very old issue. Meanwhile, I noticed the arrow styles referenced on the issue were already fixed, but the component still had some styling problems outside WordPress this PR fixes these problems.
Before:
After:
How has this been tested?
I pasted the following gist https://gist.github.com/jorgefilipecosta/6e55059202ccbcb683a56f0546ea6f93 on playground/src/index.js.
I executed the playground and verified the DateTimePicker component appears with the same look as it appears inside WordPress context e.g: the post scheduler.