Always show drag handle for nested blocks, even if single; fixes issue #12831 #15025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmdesigned
requested review from
ellatrix,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
youknowriad
added
Good First Review
aduth
approved these changes
Apr 24, 2019
| @@ -44,10 +44,10 @@ export class BlockMover extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const { onMoveUp, onMoveDown, isFirst, isLast, isDraggable, onDragStart, onDragEnd, clientIds, blockElementId, blockType, firstIndex, isLocked, instanceId, isHidden } = this.props; | |||
| const { onMoveUp, onMoveDown, isFirst, isLast, isDraggable, onDragStart, onDragEnd, clientIds, blockElementId, blockType, firstIndex, isLocked, instanceId, isHidden, rootClientId } = this.props; | |||
There was a problem hiding this comment.
This line is excessively long and could do to be split across multiple lines. I'd not consider it a blocker, but a good idea for a future refactoring.
| const { isFocused } = this.state; | ||
| const blocksCount = castArray( clientIds ).length; | ||
| if ( isLocked || ( isFirst && isLast ) ) { | ||
| if ( isLocked || ( isFirst && isLast && ! rootClientId ) ) { |
There was a problem hiding this comment.
The logic isn't entirely clear for what it is we're doing here with ( isFirst && isLast && ! rootClientId ), though the same could have been said prior to your changes. I could see this being improved with either a code comment which explains the purpose, or by separating it out as a separate named function which clearly describes its intent.
Not a blocker.
This was referenced Apr 29, 2019
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates block-mover component to always show the drag handle for blocks that are not top-level (i.e. for blocks that are children of a columns block, a group block, etc.). This allows them to be dragged outside of their parent.
Previously, no drag handle was shown if the block was the only child of its parent.
How has this been tested?
I have only tested this on my local environment (the docker setup that is bundled with the gutenberg repo).