Native mobile: don't set caret when rich-text text will get trimmed #15021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
added
the
Mobile App - i.e. Android or iOS
marecar3
reviewed
Apr 17, 2019
| @@ -624,6 +625,17 @@ export class RichText extends Component { | |||
| } | |||
| } | |||
|
|
|||
| willTrimSpaces( html ) { | |||
There was a problem hiding this comment.
This is a nice opportunity to write some unit test against this method, so that we are always sure it's working like expected, WDYT?
There was a problem hiding this comment.
Good idea! Will it be OK with you to do it in a separate PR, only to make sure we get this one merged today if possible? (to have at least a couple of days of testing until the code freeze)
There was a problem hiding this comment.
Yup, of course, I will finish testing very soon so that you can merge this one. @hypest
This was referenced Apr 22, 2019
This was referenced Apr 29, 2019
6 tasks
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing wordpress-mobile/gutenberg-mobile#871 on the native mobile side. The internal representation of rich-text in Aztec and the format-lib are not fully compatible or in-sync and we also use html to establish the communication between the two. That can lead to cases like the issue linked, where Aztec will do some trimming to remove spaces that are unimportant for html rendering, but format-lib won't so, making the caret positioning logic to get out of sync.
This PR will try to detect when such spaces will be removed and avoid telling Aztec where to put the caret and hope for the best 🤞.
How has this been tested?
Using the gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#885
Types of changes
Try to detect when such spaces will be removed and avoid telling Aztec where to put the caret. Only affecting Android.
Checklist: