Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/edit flow for blocks which have a media placeholder #14918

Closed
wants to merge 15 commits into from
+436 −207
Closed

Update/edit flow for blocks which have a media placeholder #14918

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
13146a7
adds the new edit media icon to the media-text, cover, audio, file an…
draganescu Apr 5, 2019
c7c606e
add new placeholder to edit state of media text
draganescu Apr 10, 2019
5646a72
fixes preview for media other than image
draganescu Apr 10, 2019
cab27f9
adds the new flow to the cover block
draganescu Apr 10, 2019
e3c3866
adds correct state to edit button, adds new flow to audio
draganescu Apr 10, 2019
a659801
fixed state for newly inserted audio, adds new flow to file
draganescu Apr 10, 2019
e9cd606
adds aria pressed to edit button, adds the new flow to video
draganescu Apr 10, 2019
2723aa8
adds the new edit flow to embed
draganescu Apr 11, 2019
0e7129f
removed duplicate definition
draganescu Apr 12, 2019
18fdced
adds cancel link to embed edit mode
draganescu Apr 13, 2019
d7c3b39
fixes the media preview in media + text block
draganescu Apr 15, 2019
5e23de5
new snapshot for the embed block
draganescu Apr 15, 2019
84efe80
removes the cancel link in embed initial state
draganescu Apr 19, 2019
7948ece
moves the edit button to its own group, fixes media preview margin
draganescu Apr 19, 2019
2b129f3
new snapshot for the embed block
draganescu Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
new snapshot for the embed block
@draganescu
draganescu committed May 3, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 2b129f3de470d6f8be10646cae549db812c839a3
11 changes: 0 additions & 11 deletions packages/block-library/src/embed/test/__snapshots__/index.js.snap
View file
Original file line number Diff line number Diff line change
@@ -45,17 +45,6 @@ exports[`core/embed block edit matches snapshot 1`] = `
Embed
</button>
</form>
<div
class="components-placeholder__cancel"
>
<button
class="components-button block-editor-embed-placeholder__cancel-button is-link"
title="Cancel"
type="button"
>
Cancel
</button>
</div>
</div>
</div>
`;