Update the alt text description #14668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
the
[Focus] Accessibility (a11y)
afercia
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
aduth
reviewed
Mar 27, 2019
| help={ __( 'Alternative text describes your image to people who can’t see it. Add a short description with its key details.' ) } | ||
| help={ | ||
| <Fragment> | ||
| <ExternalLink href={ __( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ) }> |
There was a problem hiding this comment.
Is it intended this link value be localized?
There was a problem hiding this comment.
We're planning to copy the W3C alt decision tree tutorial to the Handbook so it can be translated. But yes, can be non-translatable for now, will adjust.
I expect it should be It may be reasonable to omit |
|
Last commit also removes a few trailing spaces (because my editor does that automatically). |
gziolo
approved these changes
Mar 28, 2019
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14326.
In core, the alt text description in the media views has been updated with the new text discussed and recommended by the accessibility team. See https://core.trac.wordpress.org/changeset/44900. See screenshots on https://core.trac.wordpress.org/ticket/41612#comment:39. Example:
Note: I'm going to update the core string to include the word "Describe" within the link.
This PR updates the equivalent descriptions in Gutenberg for the Image and Media+Text blocks.
The new text links to the W3C "alt decision tree" tutorial and clarifies to leave the alt text empty "when the image is purely decorative". Previously, this part of the text was "if the image is not a key part of the content". Agreed the terms "key part" added cognitive load and needed to be clarified.
ExternalLinkcomponenthelpprop accepts also components: given the currentBaseControlimplementation there's no reason why it shouldn't accept components and this seems correct to mehelpprop documentation inBaseControland all the derived components needs to be updated- Type: String|WPComponent|nullbe appropriate?Screenshot: