Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in a documentation MD file #14597

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

elhardoum
Copy link
Contributor

Description

I've updated a simple typo replacing REAMD.md to README.md. The wp-org docs link to many 404 pages though, which I am not sure of the docs build process, but I believe wp-docs backend takes slugs and markdown sources from the docs/manifest.json file.

Here are the 404 links in this page:
https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/plugin-sidebar-0/plugin-sidebar-1-up-and-running/

This link on the other hand is working:

[PluginSidebar](/packages/edit-post/README.md#pluginsidebar)

How has this been tested?

No.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@elhardoum elhardoum changed the title Typo fix Typo fix in a documentation MD file Mar 24, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for fixing it 👍

@gziolo
Copy link
Member

gziolo commented Mar 25, 2019

@dd32 or @tellyworth, can you further investigate whether there were any changes in Gutenberg handbook which cause 404 errors?

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Mar 25, 2019
@gziolo gziolo merged commit e7141f9 into WordPress:master Mar 25, 2019
@gziolo
Copy link
Member

gziolo commented Mar 25, 2019

All links should work properly after this patch https://meta.trac.wordpress.org/changeset/8503 applied by @dd32. @elhardoum, can you confirm you no longer see 404 pages when navigating links?

@elhardoum
Copy link
Contributor Author

@gziolo can confirm, no more 404 pages on that handbook page. Thanks for assisting on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants