Added missing reference to lodash #14516
Conversation
A reference to the `omit` method of lodash is in the *Changing the innerBlocks* section, but the method is not defined in the code examples, causing confusion.
jakeparis
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
oandregal,
notnownikki and
youknowriad
as code owners
| @@ -194,7 +194,8 @@ E.g: a block wants to migrate a title attribute to a paragraph innerBlock. | |||
| {% ES5 %} | |||
| ```js | |||
| var el = wp.element.createElement, | |||
| registerBlockType = wp.blocks.registerBlockType; | |||
| registerBlockType = wp.blocks.registerBlockType, | |||
| omit = lodash.omit; | |||
There was a problem hiding this comment.
I'm not sure if our documentation should rely on the lodash global variable being available. It would potentially block us from one day WordPress removing lodash. Maybe a better option would be to refactor the sample code to avoid the need for omit function usage?
Any thoughts on this @gziolo, @youknowriad, @aduth?
There was a problem hiding this comment.
It could be okay to refactor, though I also don't see Lodash going anywhere anytime soon, if ever, as it's offered as a publicly-available script handle in core.
There was a problem hiding this comment.
We use also lodash in another example. I will land this change as it fixes an issue. If you have some good idea how to improve it further, let’s proceed with follow-up PR.
A reference to the
omitmethod of lodash is in the Changing the innerBlocks section, but the method is not defined in the code examples, causing confusion.Description
How has this been tested?
Screenshots
Types of changes
Checklist: