Remove the inserter title from mobile inserters #14493
Conversation
|
Showing the title in the inserter did always confuse me a little bit, so in principle and with this new context, this makes a lot of sense to me personally. I do recall the title being added at some point, I can't recall the reason, but leaving the "design feedback" label in case anyone recalls. Otherwise 👍 👍 from me. |
+1, this makes a lot of sense to me too. |
| @@ -92,7 +92,6 @@ class Inserter extends Component { | |||
| position={ position } | |||
| onToggle={ this.onToggle } | |||
| expandOnMobile | |||
| headerTitle={ title } | |||
There was a problem hiding this comment.
FWIW, this was our only usage of headerTitle. It's now dead code in Inserter. That said, there's a compatibility question of removing it, and I suppose there may be valid use-cases for it in the future.
|
Good call, @youknowriad.
Can we just call it "Block Inserter" or "Inserter" or @karmatosed's favorite, "Block Library"? I ask b/c this might be a good place to reinforce terminology with WP users. |
That's an interesting thought. This could also act as a sort of label: "Add a block" |
|
It's worth mentioning just for completeness — I believe the mobile native app uses a "bottom sheet" for the block library: https://www.material.io/design/components/sheets-bottom.html — I believe the reason we're not doing that here is that in web-mobile we can't control whether the soft keyboard is showing, and therefore anything viewport edge fixed is DOA. But mentioning in case someone can magic. (⊃｡•́‿•̀｡)⊃━☆ﾟ.*･｡ﾟ |
|
Ok I need a final direction here. Should I replace with "Add a block"? |
|
Yeah, let's do "Add a block" 👍 |
|
"Add a block" it is then! Let's do it! 🚢 |
Related #14043
On mobile, we open the inserter (all inserters, globals, in-between...) we should the title of the current post at the top but in a generic block editor world, this title doesn't make sense as we could imagine multiple inserters (widgets areas) on the same page without a title to show...
While we can provide a "config" somehow to show a custom title for each block editor, I wonder if we could avoid this complexity and just remove the title or find a generic title to show there "Add Block" or something in that vein.