-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile]Update PostTitle to apply borders when it is focused #13970
Changes from 5 commits
2f45c94
c2c0c8b
1c3db32
ab190c5
aead002
551285b
ae02d78
7f763d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
|
||
.titleContainer { | ||
padding-left: 16; | ||
padding-right: 16; | ||
padding-top: 32; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This top padding looks a bit too much on the WordPress apps. I'm not sure if this was a requirement from before or it's an adjustment made for the example apps? But not really important on this PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We did add 16pt spacing above the title in a related pr, is that what's at play here? Should we use margin instead of padding? I imagine when the block gets focused (with top/bottom borders) it'll looks odd. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see! Yes, adding the extra 16pts as margin will make the difference. Currently we don't see the top border when the title is selected. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just moved the style from one place to another, didn't change or add any styles(on the parent PR you can see that the I've put some gifs here to demonstrate how it looks wordpress-mobile/gutenberg-mobile#622 (comment) |
||
padding-bottom: 16; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinarol gutenberg doesn't support this syntax, we should remove this line if we want to merge back to master.