-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Button block wording #13933
Update Button block wording #13933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, it looks good. I would prefer to wait until someone will confirm that it is indeed the change for the description that it's expected before we proceed with merge.
A separate small thing that needs updated -- it should be "button-style." Without the dash it's a confusing phrase, and "button-style" is a bit clearer than "styled" (even though "styled" is entirely accurate). |
"button-style" it is 👍 |
@samikeijonen thanks for your another contribution 🎉 |
Thanks @michelleweber and @gziolo! |
* Update button block description by using wording about link. * Add keyword: link. * Update index.js
* Update button block description by using wording about link. * Add keyword: link. * Update index.js
Description
Closes #13923.
How has this been tested?
Tested on local, I see the wording change. And I can also search using keyword link.
Screenshots
Button description:
Search by keyword link:
Types of changes
Checklist: