-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project: Update code owners (Parser modules, RichText component) #13820
Conversation
I like how this idea allows for making things really granular. The downside however, is the maintenance overhead is greater for remembering what file people have their "ownership" applied in. This maybe could be mitigated by any automation adding a comment block listing the path the ownership was retrieved from. |
eaf401f
to
36fe4c9
Compare
I discovered the RichText entry had already been added in #13734, under the "Rich Text" categorized heading (rather than as a sibling following the entry for On this point, I commented at #13734 (comment) and #13734 (comment) with some concerns about how we currently categorize things:
|
I'm fine with moving the line to wherever you'd like. :) |
Since we discuss some changes. I would also love we create a new section where people interested in reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine as is with @dmsnell added :)
Is it the sort of thing where we adopt what we did with native files, assigning them to @ghost until someone chooses to take ownership? |
Yes, I think it would be good for start. I’ll open PR today. 👍 |
Opened #13854 as discussed. |
This pull request seeks to make a few additions to the code owners file:
block-serialization-spec-parser
,block-serialization-default-parser
)Add @aduth and @iseulde as code owners of RichText component(see Project: Update code owners (Parser modules, RichText component) #13820 (comment))The latter of these is interesting to implement. Since at most one code owner match can be made in the
CODEOWNERS
file, it's necessary to duplicate the entries from the/packages/editor
"fallback". I think it may be more something to consider more often to include ownership over more granular paths within a package (e.g. specific editor components, or specific blocks), but hand-crafting these is potentially error-prone. It may be worth considering some automation ofCODEOWNERS
being directory-specific, and aggregated up through ancestry to the top-level directory (e.g. combinepackages/editor/src/components/rich-text/CODEOWNERS
,packages/editor/CODEOWNERS
to generate the rootCODEOWNERS
file)