[RNMobile] Make placeholder text working on RichText #13699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloercoli
added
the
Mobile App - i.e. Android or iOS
|
As per chat convo I removed the |
hypest
deleted the
rnmobile/make-placeholder-text-working-on-richtext-mobile
branch
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Make placeholder text working again on RichText * Make sure the native side is always refreshed when the RichText component is cleared * Remove placeholder check
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Make placeholder text working again on RichText * Make sure the native side is always refreshed when the RichText component is cleared * Remove placeholder check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does fix an issue where the
placeholdertext wasn't working fie onRichTextfor mobile.The issue was noticed and reported since the Title block is now using the RichText component, but the problem was there on other blocks already. See Para and Heading.
Not sure when we broke it, but i guess long time ago.
Now the placeholder is visible on Para/Heading/Title blocks.
GB-mobile side PR is here: wordpress-mobile/gutenberg-mobile#544