Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase bottom padding on gallery image caption #13623

Merged

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jan 31, 2019

Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.

(This is a mirror of #8459 by @johnwatkins0, but with the addition of the gradient background edit).

Before:

screen shot 2019-01-31 at 2 30 54 pm

After:

screen shot 2019-01-31 at 2 30 54 pm

Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
@kjellr kjellr added [Feature] Blocks Overall functionality of blocks [Block] Gallery Affects the Gallery Block - used to display groups of images labels Jan 31, 2019
@kjellr kjellr self-assigned this Jan 31, 2019
@kjellr kjellr requested review from gziolo and jasmussen January 31, 2019 19:49
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer, thanks for taking care of this PR 👍

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Feb 1, 2019
@jasmussen
Copy link
Contributor

Yerp. Ship it.

@gziolo gziolo merged commit 2009bdd into master Feb 1, 2019
@gziolo gziolo deleted the update/increase-bottom-padding-on-gallery-image-caption branch February 1, 2019 08:14
daniloercoli added a commit that referenced this pull request Feb 1, 2019
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg:
  Try alternate list item jump fix. (#12941)
  Mobile bottom sheet component (#13612)
  Remove unintentional right-margin on last odd-item. (#12199)
  Introduce left and right float alignment options to latest posts block (#8814)
  Fix Google Docs table paste (#13543)
  Increase bottom padding on gallery image caption (#13623)
  Fix the editor save keyboard shortcut not working in code editor view (#13159)
  Plugin: Deprecate gutenberg_add_admin_body_class (#13572)
  Rnmobile/upload media failed state (#13615)
  Make clickOnMoreMenuItem not dependent on aria labels (#13166)
  Add: className prop support to server side render. (#13568)
  Fix: Categories Block: hierarchical Dropdown (#13567)
  Docs: Add clarification about git workflow (#13534)
  Plugin: Remove `user_can_richedit` filtering (#13608)
  eslint-plugin: Add rule `no-unused-vars-before-return` (#12828)
  Image settings button (#13597)
  Fixed wording for the color picker saturation (#13479)

# Conflicts:
#	packages/block-library/src/image/edit.native.js
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants