update the TinyMCE per Block prototype UI to match the Prototype UI style. Also make it keyboard friendly #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we be relying on or moving styles to the shared |
|
@aduth working on it |
youknowriad
force-pushed
the
update/tiny-mce-per-block-ui
branch
from
72abde0 to
14565d5
Compare
youknowriad
commented
Feb 24, 2017
| @@ -1,3 +1,4 @@ | |||
| @import '../../../../shared/index'; | |||
There was a problem hiding this comment.
I preferred including this here instead of index.html to keep the npm run dev command working
|
Updated to use the shared css in 14565d5 |
- preact has some state updating bugs
youknowriad
force-pushed
the
update/tiny-mce-per-block-ui
branch
from
882294c to
ad82af9
Compare
|
@aduth Do you think we can merge this. I know how you feel about this approach, but I'm guessing this branch is more evolved than the current prototype. Having it live could encourage some feedback on the pros/cons ? I'm also planning to write a summary of the technical aspects here : What does this approach mean for UX? What are the UX limits? How does this work? How to write a block? ... |
youknowriad
changed the title
|
I'm merging this giant PR to be able to do smaller incremental upgrades later. |
nylen
pushed a commit
that referenced
this pull request
Mar 16, 2017
…tyle. Also make it keyboard friendly (#136) * update the TinyMCE per Block prototype UI to match the Prototype UI style * Adding heading block * Adding a paragraph block and moving to React - preact has some state updating bugs * Allowing removing/merging components using backspace * Handling navigation using arrow keys * Adding a simple quote block
hypest
pushed a commit
that referenced
this pull request
Nov 2, 2018
Implements a basic ENTER interception mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #83
The idea is when you switch between prototype, you can't see the difference quickly regarding the style. This could ease comparing them technically only.