-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update edit-save documentation #13578
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2bb1ce5
Update edit examples with ES5 code
mkaz c01f0d9
Add extra explanation and links to attributes and block tutorial
mkaz 19690f9
Add two examples for attributes, edit, save
mkaz fca94dc
Update docs/designers-developers/developers/block-api/block-edit-save.md
chrisvanpatten b6fdcd4
Remove spaces.
mkaz ad6d74d
Update docs/designers-developers/developers/block-api/block-edit-save.md
nosolosw b16a492
Update docs/designers-developers/developers/block-api/block-edit-save.md
nosolosw a8da940
Update docs/designers-developers/developers/block-api/block-edit-save.md
nosolosw 8927daa
Make function defns consistent across ES5/ESNext
mkaz 3dc7a49
Add clone example for ES5
mkaz 1eb025d
Update docs/designers-developers/developers/block-api/block-edit-save.md
nosolosw 6fc0a35
Simplify ES5 example, props @nosolosw
mkaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought
isSelected
was a boolean?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't a boolean an object too :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's
0
s and1
s as well! The more specific, the better.