Plugin: Remove jQuery heartbeat-to-hooks proxying #13576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Gutenberg Plugin
13 tasks
|
With this PR post locked modal works as expected and with these changes I'd approve this if it wasn't for the existing conflicts in |
aduth
force-pushed
the
remove/jquery-heartbeat-proxy
branch
from
88f218c to
408b373
Compare
|
Thanks for looking @nosolosw ! I've pushed a rebased branch to resolve conflicts. |
oandregal
approved these changes
Feb 1, 2019
daniloercoli
added a commit
that referenced
this pull request
Feb 5, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Make the modal title styling consistent (#13669) Disable navigation block for text mode. (#12185) Fix: Linting problem in modal example code (#13671) Add myself as a code owner to the annotations (#13672) Add more reviewers to CODEOWNERS.md file (#13667) Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576) Workflow: Add repository CODEOWNERS file (#13604) Add a mobile minimum size for form fields (#13639) Update edit-save documentation (#13578) Alt image setting (#13631) Fix: Allow years lower than 1970 in DateTime component. (#13602) Using addQueryArgs to generate Manage All Reusable Blocks link (#13653) Bump plugin version to 5.0.0-rc.1 (#13652) Update lodash to 4.17.10 (#13651) Refreshed PR (#9469) Set default values of the width and height input fields according to the actual image dimensions (#7687) 12647 fix css color picker (#12747) Remove "we" from messages (#13644) Fix: Font size picker max width on mobile (#13264) Fix/issue 12501 menu item aria label ...
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This was referenced Apr 30, 2020
This was referenced May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #11781
This pull request seeks to remove the jQuery heartbeat event proxying introduced in #11781, which was intended to serve to automatically upgrade heartbeat events to corresponding hooks actions. Due to similar timeframe, it appears the changes from #11781 were made redundant as part of the following core changeset:
https://core.trac.wordpress.org/changeset/43939
Indeed, one can observe through Redux DevTools or a breakpoint in the
PostLockedModal's handling ofreceivePostLockthat the heartbeat actions are handled twice in the most recent release of Gutenberg.Testing instructions:
Repeat testing instructions from #11781, verifying there are no regressions in the behavior of the post locked modal.
Verify that each heartbeat action bound by
PostLockedModalis handled only once. You can force a heartbeat connection in your console using the following command: