Add button class to button output for styling #1354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a `button` class, styling this element on the frontend is hard :)
youknowriad
reviewed
Jun 22, 2017
| @@ -80,7 +80,7 @@ registerBlockType( 'core/button', { | |||
| const { url, text, title, align = 'none' } = attributes; | |||
|
|
|||
| return ( | |||
| <div className={ `align${ align }` }> | |||
There was a problem hiding this comment.
I would suggest blocks-button instead to avoid ambiguity with already defined button classes.
There was a problem hiding this comment.
We should take a step back and figure out a consistent way for naming these classes across all blocks. Not sure blocks-{name} will be enough. Maybe we should use the namespace of the block wp-core-button? This is something we want to get right and not change.
There was a problem hiding this comment.
All blocks have a unique attribute like: div[data-type="core/preformatted"].
added 2 commits
June 22, 2017 12:56
|
This is superceded by #1381 which adds auto-generated wrapper classes to most blocks. |
|
It's fixed now with #1381. All block have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a
buttonclass, styling this element on the frontend is hard :)