Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce onImageQueryReattach interface #13516

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Introduce onImageQueryReattach interface #13516

merged 1 commit into from
Jan 28, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Jan 25, 2019 •
edited
Loading

Note:

This builds on top of #13128, let's please merge this one first so these small changes get push into that other branch

Description

This is the supporting PR for mobile media upload progress reattach

How has this been tested?

This PR can be tested from the WPAndroid PR

Screenshots

reattachprogress

@mzorz mzorz added Mobile Web Viewport sizes for mobile and tablet devices Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jan 25, 2019
@mzorz mzorz added this to the 5.0 (Gutenberg) milestone Jan 25, 2019
This was referenced Jan 25, 2019
Merged
Merged
Merged
@marecar3
Copy link
Contributor

Nice job @mzorz!

SergioEstevao
SergioEstevao approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

marecar3
marecar3 approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzorz mzorz merged commit 93e6e95 into rnmobile/upload_media_file Jan 28, 2019
@mzorz mzorz deleted the rnmobile/media_upload_progress_reattach branch January 28, 2019 11:25
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.0 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@mzorz @marecar3 @SergioEstevao @gziolo