Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Kindle block #13510

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Amazon Kindle block #13510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9550563
Add Amazon Kindle block
Soean Jan 25, 2019
63a07d7
Add keyword
Soean Jan 25, 2019
7d44cfe
deactivate responsive and better patterns
Soean Jan 25, 2019
b1b1474
allow .asia
Soean Jan 25, 2019
b5a6c60
Better pattern
Soean Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/block-library/src/embed/core-embeds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
embedVimeoIcon,
embedRedditIcon,
embedTumbrIcon,
embedAmazonIcon,
} from './icons';

/**
Expand Down Expand Up @@ -338,4 +339,18 @@ export const others = [
},
patterns: [ /^https?:\/\/wordpress\.tv\/.+/i ],
},
{
name: 'core-embed/amazon-kindle',
settings: {
title: 'Amazon Kindle',
icon: embedAmazonIcon,
keywords: [ __( 'ebook' ) ],
responsive: false,
description: __( 'Embed Amazon Kindle content.' ),
Soean marked this conversation as resolved.
Show resolved Hide resolved
},
patterns: [
/^https?:\/\/([a-z0-9-]+\.)?(amazon|amzn)(\.[a-z]{2,4})+\/.+/i,
/^https?:\/\/(www\.)?(a\.co|z\.cn)\/.+/i,
],
Comment on lines +351 to +354
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soean: This is too eagerly catching items that aren't books and attempting to render them as such.

Try pasting any product URL matching https://www.amazon.com/gp/product/<product code>/ or https://www.amazon.com/-/<locale>/dp/<product code>/, for instance.

Example

Pasting URL https://www.amazon.com/dp/B0198CGQEE/ yields:

output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported in #27547

},
];
1 change: 1 addition & 0 deletions packages/block-library/src/embed/icons.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.