Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Safari + VoiceOver announce the screen-reader-text within buttons in the correct order #13221

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Make Safari + VoiceOver announce the screen-reader-text within buttons in the correct order #13221

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986211b
Add height auto to screen reader text within buttons.
afercia Jan 7, 2019
ba6fec7
Add reference links to the inline comment.
afercia Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/components/src/button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@
color: color(theme(outlines) shade(25%));
}
}

// Fixes a Safari+VoiceOver bug, where the screen reader text is announced not respecting the source order.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we include a reference link as part of the inline comment, perhaps to the Trac ticket or some of the debugging from the related HTML5 Boilerplate discussion, as without it, it'd be more difficult to revisit as part of future maintenance should the bug become resolved in Safari, or a better alternative proposed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.screen-reader-text {
height: auto;
}
}

@keyframes components-button__busy-animation {
Expand Down