Editor: Fix second welcome tip instructs the user to open a control that's already open.

[naogify]

Description

I fixed the text of second welcome tip's instruction Click “Settings” to open it to Click “Settings” allows toggling the sidebar.

https://github.com/WordPress/gutenberg/blob/master/packages/edit-post/src/components/header/index.js#L72

Discussed in here.

#12359

Types of changes

Change text.

[naogify]

I thought the description above is not enough. I want to add an additional explanation below.

Additional explanation

Problem

The second welcome tip instructs the user to open the Settings panel. This panel is already open, and following the instruction causes it to close.

(Quoted from : #12359 ).

How I fixed it.

Changing the instruction text to explain software behavior properly.
I changed Click “Settings” to open it.' to Click “Settings” allows toggling the sidebar..

How to check.

1. Git clone the fix/second-welcome-tip-instruction branch in local environment.
2. Ensure the localStorage in your browser is clear for your domain, so that tips appear (related: Tips: status should be user-based not browser-based #8052).
3. Open the block editor.
4. .Follow the instruction, then you will see the second welcome tip.
   (Second and third items of this list are quoted from : #12359 ).

How has this been tested?

I visually checked it in local environment and tested it by $ npm run test with 5.0.1.

Types of changes

Changing the instruction text.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[michelleweber]

I would be even more specific:

Click to cog icon to toggle the sidebar open and closed.

[naogify]

@michelleweber
I agree with making the copy more specific. I think your sentence is better than mine. Does anyone have other suggestion?

[gziolo]

Let's update with the suggestion from @michelleweber and proceed as there was no other version proposed.

[gziolo]

I updated with Click the cog icon to toggle the sidebar open and closed. as suggested.