Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing abs position on placeholder text in button #1247

Closed
wants to merge 3 commits into from
Closed

Try removing abs position on placeholder text in button #1247

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d010cbb
Try removing abs position on placeholder text in button
jasmussen Jun 19, 2017
fbc091c
Display block placeholder as translated :after pseudo-element
aduth Jun 19, 2017
37b217f
Remove dash from quote Editable text
aduth Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions blocks/library/button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ $blocks-button__height: 46px;
left: 50%;
transform: translateX( -50% );
}

.blocks-editable__tinymce[data-is-empty="true"]:before {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be so specific to button, or should we set this as the default for all empty Editable placeholders?

https://github.com/WordPress/gutenberg/blob/cab8713/blocks/editable/style.scss#L49

position: inherit;
}
}

.editor-visual-editor__block[data-type="core/button"] {
Expand Down