Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: use consistent color values (RGB/HEX/HSL) #12194

Closed
wants to merge 2 commits into from
Closed

i18n: use consistent color values (RGB/HEX/HSL) #12194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22f44f
i18n: use consistent color values (RGB/HEX/HSL)
ramiy Nov 21, 2018
3287b6a
HEX => Hex
ramiy Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/src/color-picker/inputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class Inputs extends Component {
} else if ( this.state.view === 'rgb' ) {
this.setState( { view: 'hsl' } );

speak( __( 'Hue/saturation/lightness mode active' ) );
speak( __( 'HSL mode active' ) );
ramiy marked this conversation as resolved.
Show resolved Hide resolved
} else if ( this.state.view === 'hsl' ) {
if ( this.props.hsl.a === 1 ) {
this.setState( { view: 'hex' } );
Expand Down Expand Up @@ -162,7 +162,7 @@ export class Inputs extends Component {
return (
<div className="components-color-picker__inputs-fields">
<Input
label={ __( 'Color value in hexadecimal' ) }
label={ __( 'Color value in Hex' ) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't hexadecimal clearer to understand and easier to translate than Hex (which should be lowercase btw)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Industry standard is Hex, or in some case HEX. The full hexadecimal is usually used in documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, We are already using Hex in other string, this PR is for creating consistency in color values.

valueKey="hex"
value={ this.props.hex }
onChange={ this.handleChange }
Expand Down