Add a minimal multi-selection block panel #12050
Conversation
|
Code wise, it looks good. My concern is that we repeat |
gziolo
added
[Priority] High
|
Let me try and push a little change. |
|
Okay, I pushed a little change:
This makes it look more like the normal inspector card:
I agree, when seeing this, with Gzregorz — can we make it so the "Block" tab title never changes? I.e. it should be this:
|
|
I love it 👍 |
|
|
||
| function MultiSelectionInspector( { blocks } ) { | ||
| return ( | ||
| <div className="editor-block-inspector__card"> |
There was a problem hiding this comment.
Instead of reusing a className, I'd just duplicate this style in a style.scss file specific to this component and rename this class editor-multi-selection-inspector__card.
Later, we should think at a generic card component or something.
There was a problem hiding this comment.
The other classNames should also be renamed.
There was a problem hiding this comment.
The other classNames should also be renamed.
Which ones? Did I miss any?
|
Thanks for the tweaks 👍 |
|
Forgot one, that I just pushed. I'll need help changing the tab label, though — so it always says "Block". |
|
Okay I fixed the block tab:
I think this is good. |
|
There's still some things we can remove :) I'm pushing a commit |
|
Thanks, Riad. I'm done with my changes. You can take it from here. Here's why I think the block tab change is good, just for posterity:
It's less jumpy, simpler, more consistent. |
youknowriad
force-pushed
the
add/mimimal-multiselection-inspector
branch
from
1a34599 to
edfd969
Compare
|
I tweaked the last commit, we just need a ✅ now :) |
|
@gziolo, you're up! :D |
| { sprintf( __( '%d blocks' ), blocks.length ) } | ||
| </div> | ||
| <div className="editor-multi-selection-inspector__card-description"> | ||
| { sprintf( __( '%d words.' ), wordCount( serialize( blocks ), 'words' ) ) } |
There was a problem hiding this comment.
This needs to use _n() instead of __(). Also, there is no translators comment.
| } showColors /> | ||
| <div className="editor-multi-selection-inspector__card-content"> | ||
| <div className="editor-multi-selection-inspector__card-title"> | ||
| { sprintf( __( '%d blocks' ), blocks.length ) } |
There was a problem hiding this comment.
This needs to use _n() instead of __(). Also, there is no translators comment.
Addresses an issue introduced in #12050.
|
Created #12054 to fix this. |
Addresses an issue introduced in #12050.
Let's avoid the "coming soon" message in the RC and replace the multi-selection inspector panel with a minimal panel with some numbers.